Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync-strategy field to output of planner #2171

Merged
merged 1 commit into from Jul 2, 2021
Merged

Add sync-strategy field to output of planner #2171

merged 1 commit into from Jul 2, 2021

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 2, 2021

What this PR does / why we need it:

PlanPreview feature needs this field to build its result.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv nghialv changed the title Add sync-strategy to output of planner Add sync-strategy field to output of planner Jul 2, 2021
@khanhtc1202
Copy link
Member

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jul 2, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.42%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/app/piped/planner/ecs/ecs.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/planner/kubernetes/kubernetes.go Planner.Plan 0.00% 0.00% +0.00%

@nakabonne
Copy link
Member

👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 18679a6 into master Jul 2, 2021
@pipecd-bot pipecd-bot deleted the planner branch July 2, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants