Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Envoy gRPC stats for all methods #2185

Merged
merged 1 commit into from Jul 6, 2021
Merged

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:
This PR enables two things:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.24%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jul 6, 2021
@nghialv
Copy link
Member

nghialv commented Jul 6, 2021

Nice.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit a6f6762 into master Jul 6, 2021
@pipecd-bot pipecd-bot deleted the enable-all-stats branch July 6, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants