Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide to run Piped on CloudRun #2231

Merged
merged 5 commits into from Jul 13, 2021
Merged

Add guide to run Piped on CloudRun #2231

merged 5 commits into from Jul 13, 2021

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 13, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.00%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

🚀
/lgtm

@pipecd-bot pipecd-bot removed the lgtm label Jul 13, 2021
remote: git@github.com:{GIT_ORG}/{GIT_REPO}.git
branch: {GIT_BRANCH}

# Optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Optional comments like these makes it clear what to configure at least.

…ling-on-cloudrun.md

Co-authored-by: Ryo Nakao <ryo@nakao.dev>
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.00%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.00%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

Well documented. There you go!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 79fb152 into master Jul 13, 2021
@pipecd-bot pipecd-bot deleted the operator branch July 13, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants