Ensure that command result should be reported even when the handling context's deadline passes #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…context's deadline passes
nghialv
commented
Jul 26, 2021
| @@ -262,6 +261,7 @@ func (h *Handler) handleCommand(ctx context.Context, cmd model.ReportableCommand | |||
| if err != nil { | |||
| logger.Error("failed to marshal command result", zap.Error(err)) | |||
| } | |||
|
|
|||
| if err := cmd.Report(ctx, model.CommandStatus_COMMAND_FAILED, nil, output); err != nil { | |||
There was a problem hiding this comment.
With the current code, this Report function will not be executed when the command context's deadline passes.
|
/lgtm |
|
Code coverage for golang is
|
|
🚀 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
/changelog |
|
@nghialv: Changelog has been generated in response to this comment. DetailsChangelog since v0.13.0Notable Changes
Internal Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: