Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable insights tab on header #2373

Merged
merged 1 commit into from Aug 20, 2021
Merged

Enable insights tab on header #2373

merged 1 commit into from Aug 20, 2021

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Aug 20, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1257

Does this PR introduce a user-facing change?:

Enable insights tab on header

@nakabonne
Copy link
Member

If I understand right, it's not available yet. We can access the page by typing path manually, but tell me why it's needed.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.10%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member Author

khanhtc1202 commented Aug 20, 2021

If I understand right, it's not available yet. We can access the page by typing path manually, but tell me why it's needed.

Sorry for not clarify the context of this change 🙏 We're going to roll out this feature and just want to make it more friendly to access (click tab on the header). Currently, I'm thinking about move the applications count badges to the insights page too, so make it easier to be accessed would be nice 😄

@nakabonne
Copy link
Member

Ah, that's what you're trying. Now I got it 👍
/lgtm

@khanhtc1202
Copy link
Member Author

Ah, that's what you're trying. Now I got it 👍

Yep 🙌 Basically, It will keep its status (not fully available) but will show

  • applications count badges (all badges instead of just registered application kind)
  • all graphs with text like "Comming soon"

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.50%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Aug 20, 2021

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 98a22bd into master Aug 20, 2021
@pipecd-bot pipecd-bot deleted the enable-insight-routing branch August 20, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore a link to the insights in the v1 release
4 participants