Force regenerate uid for controlplane overview and piped process board #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage for golang is |
|
I'm not sure exactly but is Grafana able to re-generate UID automatically? |
Looks like it will do that in case importing board configuration without the UID |
|
Okay, let's give it a try anyway. |
|
Great! |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
pipecd-bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
**What this PR does / why we need it**: follow PR #2400 **Which issue(s) this PR fixes**: Fixes # **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. --> ```release-note NONE ``` This PR was merged by Kapetanios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The UID used for control-plane Overview (former Cache) and piped Process (former Instance) is reused caused by board's name changed, this PR removes those conflicted UIDs to force Grafana to generate new UIDs on importing those boards. Will update generated UIDs for those boards by separated PR later.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: