Empower all commands to handle input to stdin #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage for golang is
|
|
Nice extension. |
|
/approve |
|
Just fixed a conflict. Let me self-approve. |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
Code coverage for golang is
|
This was referenced Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes it possible to pass the input to stdin to all commands.
Due to this, it renamed
cli.Telemetrytocli.Input. If you think about it, originally logger isn't in the telemetry context so not odd to change. This brought flexibility to us for a variety of other inputs to be propagated to each command.The initial reason why I looked to make this change is so that we can pass the plaintext file to
pipectl encryptcommand via stdin.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: