Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ioutil package from Pipecd's dependencies #2616

Merged
merged 3 commits into from Oct 12, 2021
Merged

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Oct 11, 2021

What this PR does / why we need it:

Remove ioutil package since the APIs of ioutil are deprecated.

Confirmed ioutil package is completely removed with

╭─ ~/workspace/pipecd/pipe  remove-ioutil !1 ────────────────────── ✔  11:15:54 
╰─ ag --go "ioutil"

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/git/commit_test.go
--- pkg/git/commit_test.go.orig
+++ pkg/git/commit_test.go
@@ -28,7 +28,7 @@
 	require.NoError(t, err)
 
 	expected := []Commit{
-		Commit{
+		{
 			Author:          "nghialv",
 			Committer:       "kapetanios-robot",
 			CreatedAt:       1565752022,
@@ -36,7 +36,7 @@
 			AbbreviatedHash: "74e20ed",
 			Message:         "wip",
 		},
-		Commit{
+		{
 			Author:          "Le Van Nghia",
 			Committer:       "kapetanios-robot",
 			CreatedAt:       1565749682,
@@ -59,7 +59,7 @@
 
 This PR was merged by Kapetanios.`,
 		},
-		Commit{
+		{
 			Author:          "nghialv",
 			Committer:       "kapetanios-robot",
 			CreatedAt:       2565752022,

@khanhtc1202
Copy link
Member Author

/golinter fmt

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.62%. This pull request decreases coverage by -0.12%.

File Function Base Head Diff
pkg/app/piped/executor/analysis/metrics_analyzer.go metricsAnalyzer.analyzeWithPrevious 0.00% 0.00% +0.00%
pkg/app/piped/executor/analysis/metrics_analyzer.go metricsAnalyzer.analyzeWithCanaryBaseline 0.00% 0.00% +0.00%
pkg/app/piped/executor/analysis/metrics_analyzer.go metricsAnalyzer.analyzeWithCanaryPrimary 0.00% 0.00% +0.00%
pkg/app/piped/executor/analysis/metrics_analyzer.go compare 73.68% 78.95% +5.26%

@khanhtc1202 khanhtc1202 changed the title Remove ioutil Remove ioutil package from Pipecd's dependencies Oct 12, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.62%. This pull request decreases coverage by -0.12%.

File Function Base Head Diff
pkg/app/piped/executor/analysis/metrics_analyzer.go metricsAnalyzer.analyzeWithPrevious 0.00% 0.00% +0.00%
pkg/app/piped/executor/analysis/metrics_analyzer.go metricsAnalyzer.analyzeWithCanaryBaseline 0.00% 0.00% +0.00%
pkg/app/piped/executor/analysis/metrics_analyzer.go metricsAnalyzer.analyzeWithCanaryPrimary 0.00% 0.00% +0.00%
pkg/app/piped/executor/analysis/metrics_analyzer.go compare 73.68% 78.95% +5.26%

@khanhtc1202 khanhtc1202 marked this pull request as ready for review October 12, 2021 02:10
@nakabonne
Copy link
Member

Nice work. They all seem to be the correct replacements.
/lgtm

@nghialv
Copy link
Member

nghialv commented Oct 12, 2021

Feel so good!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants