Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded flag to specify tag from pipectl #2749

Merged
merged 1 commit into from Nov 5, 2021

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:
We currently attempt to register labels via configuration declaratively.

Which issue(s) this PR fixes:

Closes #2741

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202
Copy link
Member

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Nov 5, 2021
@ono-max
Copy link
Member

ono-max commented Nov 5, 2021

/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Nov 5, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit dcbb875 into master Nov 5, 2021
@pipecd-bot pipecd-bot deleted the remove-unnndeded-flag branch November 5, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enabled pipectl to specify tags after we settled on using tags
5 participants