Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise piped connection status UI color #2958

Merged
merged 1 commit into from Dec 20, 2021
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Change the dot which shows piped connection status color as below

Screen Shot 2021-12-18 at 0 27 35

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.41%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 82.67%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

By overriding CSS, we're able to do that without bumping material-ui to v5 as you mentioned!
/lgtm

@nghialv
Copy link
Member

nghialv commented Dec 20, 2021

Nice.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants