Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filedb package #3163

Merged
merged 4 commits into from Jan 30, 2022
Merged

Add filedb package #3163

merged 4 commits into from Jan 30, 2022

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

Unabled to get changed files of pull request.

Details
Error: rpc error: code = NotFound desc = not found

@pipecd-bot
Copy link
Collaborator

KAPETANIOS

Failed while validating Kapetanios configuration.

Details
Error: rpc error: code = NotFound desc = not found

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.69%. This pull request does not change code coverage.

Co-authored-by: knanao <50069775+knanao@users.noreply.github.com>
@pipecd-bot
Copy link
Collaborator

GO_LINTER

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/datastore/filedb/filedb.go
--- pkg/datastore/filedb/filedb.go.orig
+++ pkg/datastore/filedb/filedb.go
@@ -17,9 +17,10 @@
 import (
 	"context"
 
+	"go.uber.org/zap"
+
 	"github.com/pipe-cd/pipecd/pkg/datastore"
 	"github.com/pipe-cd/pipecd/pkg/filestore"
-	"go.uber.org/zap"
 )
 
 type FileDB struct {

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.69%. This pull request does not change code coverage.


"github.com/pipe-cd/pipecd/pkg/datastore"
"github.com/pipe-cd/pipecd/pkg/filestore"
"go.uber.org/zap"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to a separate import group.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.69%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jan 30, 2022

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants