Implement sync-by-replace option #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipecd-bot
reviewed
Feb 10, 2022
| KindClusterRole = "ClusterRole" | ||
| KindClusterRoleBinding = "ClusterRoleBinding" | ||
| KindNameSpace = "NameSpace" | ||
| KindDeployment = "Deployment" |
There was a problem hiding this comment.
exported const KindDeployment should have comment (or a comment on this block) or be unexported
|
Code coverage for golang is
|
|
Code coverage for golang is
|
knanao
reviewed
Feb 10, 2022
Co-authored-by: knanao <50069775+knanao@users.noreply.github.com>
|
The following files are not gofmt-ed. By commenting pkg/app/piped/executor/kubernetes/kubernetes.go--- pkg/app/piped/executor/kubernetes/kubernetes.go.orig
+++ pkg/app/piped/executor/kubernetes/kubernetes.go
@@ -214,26 +214,26 @@
for _, m := range manifests {
annotation := m.GetAnnotations()[provider.LabelSyncReplace]
// Do not replace CRD because replace might delete CRD instance
- if annotation != provider.UserReplaceTrue || m.Key.IsCRD() {
- if err := applier.ApplyManifest(ctx, m); err != nil {
- lp.Errorf("Failed to apply manifest: %s (%w)", m.Key.ReadableLogString(), err)
- return err
- }
- lp.Successf("- applied manifest: %s", m.Key.ReadableLogString())
- continue
- }
- // Always try to replace first and create if it fails due to resource not found error.
- // This is because we cannot know whether resource already exists before executing command.
- err := applier.ReplaceManifest(ctx, m)
- if errors.Is(err, provider.ErrNotFound) {
- lp.Infof("Specified resource does not exist, so create the resource: %s (%w)", m.Key.ReadableLogString(), err)
- err = applier.CreateManifest(ctx, m)
- }
- if err != nil {
- lp.Errorf("Failed to replace or create manifest: %s (%w)", m.Key.ReadableLogString(), err)
- return err
- }
- lp.Successf("- replaced or created manifest: %s", m.Key.ReadableLogString())
+ if annotation != provider.UserReplaceTrue || m.Key.IsCRD() {
+ if err := applier.ApplyManifest(ctx, m); err != nil {
+ lp.Errorf("Failed to apply manifest: %s (%w)", m.Key.ReadableLogString(), err)
+ return err
+ }
+ lp.Successf("- applied manifest: %s", m.Key.ReadableLogString())
+ continue
+ }
+ // Always try to replace first and create if it fails due to resource not found error.
+ // This is because we cannot know whether resource already exists before executing command.
+ err := applier.ReplaceManifest(ctx, m)
+ if errors.Is(err, provider.ErrNotFound) {
+ lp.Infof("Specified resource does not exist, so create the resource: %s (%w)", m.Key.ReadableLogString(), err)
+ err = applier.CreateManifest(ctx, m)
+ }
+ if err != nil {
+ lp.Errorf("Failed to replace or create manifest: %s (%w)", m.Key.ReadableLogString(), err)
+ return err
+ }
+ lp.Successf("- replaced or created manifest: %s", m.Key.ReadableLogString())
}
lp.Successf("Successfully applied %d manifests", len(manifests))
|
|
Pretty good! |
|
Code coverage for golang is
|
|
Change option name from |
Got it. Look nice. |
|
Code coverage for golang is
|
|
Great work! Thank you. |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement pipecd.dev/sync-by-replace: "true" option. This enable use of kubectl replace/create instead of kubectl apply.
With this change, CRD is not supported for simplicity.
Which issue(s) this PR fixes:
Fixes #3173
Does this PR introduce a user-facing change?: