New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output artifact versions for ecs deployment #3385
Conversation
Code coverage for golang is
|
td, _ := parseTaskDefinition(tc.input) | ||
versions, err := FindArtifactVersions(td) | ||
assert.Equal(t, tc.expectedErr, err != nil) | ||
assert.Equal(t, tc.expected, versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert.Equal(t, tc.expected, versions) | |
assert.ElementsMatch(t, tc.expected, versions) |
should use this to avoid order of results while checking
}, | ||
} | ||
|
||
for _, tc := range testcases { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for _, tc := range testcases { | |
for _, tc := range testcases { | |
tc := tc |
@@ -78,3 +80,205 @@ cpu: 256 | |||
}) | |||
} | |||
} | |||
|
|||
func TestFindArtifactVersions(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func TestFindArtifactVersions(t *testing.T) { | |
func TestFindArtifactVersions(t *testing.T) { | |
t.Parallel() | |
Code coverage for golang is
|
Great work. |
674e335
to
4b32472
Compare
Code coverage for golang is
|
Nice catch |
What this PR does / why we need it:
This PR changes to output artifact versions for ecs development.
Which issue(s) this PR fixes:
A part of #3303
Does this PR introduce a user-facing change?: