Fix unable to filter model correctly in case of filter options contain omitted field #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage for golang is
|
khanhtc1202
changed the title
|
/hold |
|
/hold cancel |
|
Code coverage for golang is
|
|
Code coverage for golang is
|
pipecd-bot
reviewed
Apr 5, 2022
pkg/datastore/filedb/filter.go
Outdated
| var valNum, operandNum int64 | ||
| var ( | ||
| valNum, operandNum float64 | ||
| valCasted bool = true |
There was a problem hiding this comment.
should omit type bool from declaration of var valCasted; it will be inferred from the right-hand side
pkg/datastore/filedb/filter.go
Outdated
| var ( | ||
| valNum, operandNum float64 | ||
| valCasted bool = true | ||
| operandCasted bool = true |
There was a problem hiding this comment.
should omit type bool from declaration of var operandCasted; it will be inferred from the right-hand side
|
Code coverage for golang is
|
|
Code coverage for golang is
|
knanao
reviewed
Apr 6, 2022
Co-authored-by: knanao <50069775+knanao@users.noreply.github.com>
|
Code coverage for golang is
|
|
Got it. 👍 /approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The root cause of this issue is that we have to convert model objects to
map[string]interface{}in order to make filter logic works. The previous converting logic does: marshal object first, then unmarshal raw byte tomap[string]interface{}.Since our objects which are generated by protobuf are always contain
omitemptyas its json tag. While doing "first marshal", all fields with zero value will be omitted and unable to filter the object correctly if the filter options contain those omitted fields.Through this PR, I change to using protojson marshaler instead of encoding/json marshal, which has an option to enable us to keep zero value for fields with
omitemptyjsontag.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: