New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed web static into the pipecd docker image #3549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm
Makefile
Outdated
@@ -130,3 +130,10 @@ update-docsy: | |||
.PHONY: codegen | |||
codegen: | |||
docker run --rm -v ${PWD}:/repo -it gcr.io/pipecd/codegen:0.7.0 /repo | |||
|
|||
.PHONY: build/frontend | |||
build/frontend: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is build-frontend
more proper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 . Let me fix as your suggestion.
Thank you! |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: