New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit height for possible multiple rows column on application list page #3567
Conversation
Nice improvement. |
/hold |
/hold cancel |
Code coverage for javascript is
|
/lgtm |
</Link> | ||
<br /> | ||
</> | ||
<TableCell> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Artifact Versions
should be fixed as well as Labels to resolve that support case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's. At L163 👀 We can not directly set max-height to TableCell so I use a trick to add div to the TableCell and set max-height there. Same thing I did at L149. (The demo video is only for labels column does not mean I did not update the versions column)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I missed this one.
Thanks.
What this PR does / why we need it:
Kapture.2022-04-22.at.09.31.41.mp4
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: