Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit height for possible multiple rows column on application list page #3567

Merged
merged 2 commits into from Apr 22, 2022

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Apr 22, 2022

What this PR does / why we need it:

Kapture.2022-04-22.at.09.31.41.mp4

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.55%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Apr 22, 2022

Nice improvement.
/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 77.47%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member Author

/hold

@khanhtc1202
Copy link
Member Author

/hold cancel

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.55%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 77.50%. This pull request increases coverage by 0.03%.

File Base Head Diff
src/modules/commands/index.ts 90.62% 93.75% +3.12%

@nghialv
Copy link
Member

nghialv commented Apr 22, 2022

/lgtm

</Link>
<br />
</>
<TableCell>
Copy link
Member

@knanao knanao Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Artifact Versions should be fixed as well as Labels to resolve that support case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's. At L163 👀 We can not directly set max-height to TableCell so I use a trick to add div to the TableCell and set max-height there. Same thing I did at L149. (The demo video is only for labels column does not mean I did not update the versions column)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I missed this one.
Thanks.

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by knanao.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants