Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove google-cloud-sdk-324.0.0-linux-x86.tar.gz from pipecd base image #3693

Merged
merged 1 commit into from May 30, 2022
Merged

Remove google-cloud-sdk-324.0.0-linux-x86.tar.gz from pipecd base image #3693

merged 1 commit into from May 30, 2022

Conversation

Szarny
Copy link
Contributor

@Szarny Szarny commented May 30, 2022

What this PR does / why we need it:

Add rm command to remove used tar file.

# BEFORE
$ kubectl exec -it pipecd-server-99885cc9f-x9xlq -- ls
bin                                        proc
dev                                        root
etc                                        run
google-cloud-sdk                           sbin
google-cloud-sdk-324.0.0-linux-x86.tar.gz  srv
home                                       sys
lib                                        tmp
media                                      usr
mnt                                        var
opt                                        web

# AFTER
# google-cloud-sdk-324.0.0-linux-x86.tar.gz is removed
$ kubectl exec -it pipecd-server-ddb5747c9-2m6q4 -- ls
bin               lib               root              tmp
dev               media             run               usr
etc               mnt               sbin              var
google-cloud-sdk  opt               srv               web
home              proc              sys

Which issue(s) this PR fixes:

Fixes #3558

Does this PR introduce a user-facing change?:

NONE

@Szarny Szarny self-assigned this May 30, 2022
@Szarny Szarny requested a review from knanao as a code owner May 30, 2022 03:57
knanao
knanao approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :D

khanhtc1202
khanhtc1202 approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go 👍

@khanhtc1202 khanhtc1202 merged commit 8d6d7ee into pipe-cd:master May 30, 2022
@github-actions github-actions bot mentioned this pull request May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

@knanao knanao knanao approved these changes

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

Assignees

@Szarny Szarny

Labels
area/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove google-cloud-sdk-324.0.0-linux-x86.tar.gz from pipecd base image
3 participants
@Szarny @khanhtc1202 @knanao