New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag for launcher to Makefile #3742
Conversation
run/launcher: CONFIG_FILE ?= | ||
run/launcher: INSECURE ?= false | ||
run/launcher: | ||
go run cmd/launcher/main.go launcher --config-file=$(CONFIG_FILE) --insecure=$(INSECURE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about making this as a part of make run/piped
and control which will be run using a flag like LAUNCHER=true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add LAUNCHER flag to run/piped! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now we can handle which to use like make run/piped LAUNCHER={true|false}
run/launcher
target to MakefileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
What this PR does / why we need it:
Add
LAUNCHER
flag torun/piped
to execute the launcher more easily.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: