Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment in docs #4035

Merged
merged 2 commits into from Dec 1, 2022
Merged

Fix comment in docs #4035

merged 2 commits into from Dec 1, 2022

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 1, 2022 03:59
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce catch

@khanhtc1202 khanhtc1202 merged commit fa73262 into master Dec 1, 2022
@khanhtc1202 khanhtc1202 deleted the fix-cmt branch December 1, 2022 04:05
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
knanao pushed a commit that referenced this pull request Dec 2, 2022
* Fix comment in docs

* Remove unneeded char
knanao added a commit that referenced this pull request Dec 2, 2022
* Update release note (#4032)

* Avoid the incorrect conversion between integer types (#4034)

* Avoid the incorrect conversion between integer types

* Fix the error text

* Fix comment in docs (#4035)

* Fix comment in docs

* Remove unneeded char

* Make chunkMaxCount configurable for Insight collector (#4036)

* Remove unneeded code (#4038)

* Refactor api loading for Insights data on web (#4039)

* Move api loading logic from insight-header to insight

* Disable api loading for deployment insights

* Release v0.40.1 (#4040)

* Release v0.40.1

* Update release note

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Co-authored-by: nghialv <nghialv2607@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants