-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new branch if makePullRequest is true in git config #4395
Create a new branch if makePullRequest is true in git config #4395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some nits.
docs/content/en/docs/user-guide/managing-piped/configuration-reference.md
Outdated
Show resolved
Hide resolved
59da8e7
to
84fa9b1
Compare
docs/content/en/docs-v0.43.x/user-guide/configuration-reference.md
Outdated
Show resolved
Hide resolved
And besides, for simplicity, I think we can make this ref: https://pipecd.dev/docs/user-guide/event-watcher/#use-the-pipe-directory |
d2cffcc
to
20222a3
Compare
20222a3
to
c6ae27a
Compare
Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
bbe6f49
to
f53a9b5
Compare
Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
f53a9b5
to
e1a4e41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'll check the behavior 👍 |
* add new branch flag when commit changes in eventwatcher Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add createPullRequest flag to event watcher config instead of git config Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix test Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * push commit if the branch is new in event watcher Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix docs-v0.43.x Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix docs Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * replace createPullRequest with makePullRequest Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * renamed getBranchName to makeBranchName Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * remove makePullRequest from EventWatcherEvent Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * retry push commits in execute func Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix how to push new branch Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * use map for branchname Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * use branchHandledEvents map Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * use errors.Join Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * remove docs Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * remove handledEvents Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * avoid using '!' Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * rearrange package Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> --------- Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
makePullRequest: false
|
not set makePullRequest
|
It works fine! Thank you! @nnnkkk7 |
What this PR does / why we need it:
Add createPullRequest flag to event watcher config, to create new branch when commit changes in event watcher.
Which issue(s) this PR fixes:
Part of issue #4360
Does this PR introduce a user-facing change?: