Update quickstart to support arm hardware(ex: M1) #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitbluf
requested review from
nghialv,
khanhtc1202 and
kentakozuka
as code owners
Update chart values and templates for mysql deployment Signed-off-by: gitbluf <gitbluf@tuta.io>
Signed-off-by: gitbluf <gitbluf@tuta.io>
Signed-off-by: gitbluf <gitbluf@tuta.io>
khanhtc1202
reviewed
Jun 30, 2023
|
Thanks @gitbluf , overall looks great, just a small nits 🙌 |
Signed-off-by: gitbluf <gitbluf@tuta.io>
khanhtc1202
changed the title
kentakozuka
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Add: arch selection for mysql image Update chart values and templates for mysql deployment Signed-off-by: gitbluf <gitbluf@tuta.io> * Update: MySql image selector function to be more descriptive Signed-off-by: gitbluf <gitbluf@tuta.io> * Remove: mysql image set on piped installation Signed-off-by: gitbluf <gitbluf@tuta.io> * Update method name Signed-off-by: gitbluf <gitbluf@tuta.io> --------- Signed-off-by: gitbluf <gitbluf@tuta.io>
kentakozuka
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Add: arch selection for mysql image Update chart values and templates for mysql deployment Signed-off-by: gitbluf <gitbluf@tuta.io> * Update: MySql image selector function to be more descriptive Signed-off-by: gitbluf <gitbluf@tuta.io> * Remove: mysql image set on piped installation Signed-off-by: gitbluf <gitbluf@tuta.io> * Update method name Signed-off-by: gitbluf <gitbluf@tuta.io> --------- Signed-off-by: gitbluf <gitbluf@tuta.io> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
kentakozuka
added a commit
that referenced
this pull request
Jul 12, 2023
) * Update web deps (#4451) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Update quickstart to support arm hardware(ex: M1) (#4457) * Add: arch selection for mysql image Update chart values and templates for mysql deployment Signed-off-by: gitbluf <gitbluf@tuta.io> * Update: MySql image selector function to be more descriptive Signed-off-by: gitbluf <gitbluf@tuta.io> * Remove: mysql image set on piped installation Signed-off-by: gitbluf <gitbluf@tuta.io> * Update method name Signed-off-by: gitbluf <gitbluf@tuta.io> --------- Signed-off-by: gitbluf <gitbluf@tuta.io> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Support AWS LoadBalancer with multi listeners (#4462) * Support AWS LoadBalancer with multi listeners Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Fix go array index Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Rename symbol Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Specify Version For Templating Tools (#4463) * specify version for templating tools Signed-off-by: Viet Anh Pham Nhu <nhuvietanh271098@gmail.com> * Handle Error Both Install Helm And Kustomize Signed-off-by: Viet Anh Pham Nhu <nhuvietanh271098@gmail.com> --------- Signed-off-by: Viet Anh Pham Nhu <nhuvietanh271098@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Output usage only when flag parsing fails #4381 (#4464) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix ECS rollback stage does not remove canary created tasks (#4465) * Fix cannot remove canary created task Signed-off-by: ductnn <trannhuduc531998@gmail.com> * Fix reuse clean function Signed-off-by: ductnn <trannhuduc531998@gmail.com> * Update logs message for ECS routing stage rollback Signed-off-by: ductnn <trannhuduc531998@gmail.com> --------- Signed-off-by: ductnn <trannhuduc531998@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Update logs message for ECS routing stage executor (#4466) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * fix: update deprecated apiVersion since gke removed (#4469) GoogleCloudPlatform/gke-managed-certs#58 Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Skip update AppState when no log updates (#4482) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: gitbluf <gitbluf@tuta.io> Signed-off-by: Viet Anh Pham Nhu <nhuvietanh271098@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: ductnn <trannhuduc531998@gmail.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: Marko Petrovic <22802784+gitbluf@users.noreply.github.com> Co-authored-by: Viet Anh Pham Nhu <40441000+anhpnv@users.noreply.github.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Co-authored-by: Duc Tran <trannhuduc531998@gmail.com> Co-authored-by: Henry Vu <26101787+hungran@users.noreply.github.com> Co-authored-by: Kurochan <kuro@kurochan.org>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Currently quickstart doesn't work on ARM machines unless manual steps are taken.
Which issue(s) this PR fixes: #4116
Fixes # Quckstart for arm architecture CPU's (tested on M1 Pro)
Update Helm chart values to support different mysql image.
Does this PR introduce a user-facing change?: Yes