Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify severity when unable to determine versions in Kubernetes #4493

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

kanata2
Copy link
Contributor

@kanata2 kanata2 commented Jul 13, 2023

What this PR does / why we need it:
This error is not critical error and there are cases that users have no way to fix.
In addition to this, the severity of same error in other providers(cloudrun, lambda, ecs, terraform) is already set WARN.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

No

Signed-off-by: Naoki Kanatani <k12naoki@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you 🙏

@khanhtc1202 khanhtc1202 merged commit d650b77 into pipe-cd:master Jul 14, 2023
12 checks passed
@kanata2 kanata2 deleted the rethink-log-level branch July 18, 2023 02:18
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants