Add application related labels to deployment_status metric #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanata2
requested review from
nghialv,
khanhtc1202 and
kentakozuka
as code owners
kanata2
force-pushed
the
add-app-related-label-to-metric
branch
from
4e7970c
to
1868cb0
Compare
Fixes: pipe-cd#4475 Signed-off-by: Naoki Kanatani <k12naoki@gmail.com>
kanata2
force-pushed
the
add-app-related-label-to-metric
branch
from
1868cb0
to
6177354
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4520 +/- ##
=======================================
Coverage 30.03% 30.03%
=======================================
Files 220 220
Lines 25761 25761
=======================================
Hits 7737 7737
Misses 17379 17379
Partials 645 645 ☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Jul 21, 2023
| @@ -189,7 +189,7 @@ func (p *planner) Run(ctx context.Context) error { | |||
| } | |||
|
|
|||
| defer func() { | |||
| controllermetrics.UpdateDeploymentStatus(p.deployment.Id, p.doneDeploymentStatus, p.deployment.Kind, p.deployment.PlatformProvider) | |||
| controllermetrics.UpdateDeploymentStatus(p.deployment, p.deployment.Status) | |||
There was a problem hiding this comment.
@kentakozuka should it p.doneDeploymentStatus instead? 🤔
There was a problem hiding this comment.
Thanks for pointing out!
Let me fix it 👍
There was a problem hiding this comment.
No prob. It was my fault too.
khanhtc1202
pushed a commit
that referenced
this pull request
Jul 26, 2023
Fixes: #4475 Signed-off-by: Naoki Kanatani <k12naoki@gmail.com>
khanhtc1202
added a commit
that referenced
this pull request
Jul 26, 2023
* Release v0.44.1 (#4448) --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Release v0.44.2 (#4486) * Release v0.44.2 * Add release blog --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add application related labels to deployment_status metric (#4520) Fixes: #4475 * Fix deployment status use an incorrect status (#4521) * Disable terraform drift detection (#4522) * Add driftDetectionEnabled to terraform provider config * Fix docs and comments --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: Naoki Kanatani <k12naoki@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: Naoki Kanatani <k12naoki@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added application_id, application_name labels to deployment_status metric.
Which issue(s) this PR fixes:
Fixes: #4475
Does this PR introduce a user-facing change?: