Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambda configuration #4557

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

sivchari
Copy link
Member

What this PR does / why we need it:

I fiexd Lambda updateconfiguration.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202
Copy link
Member

Could you remove files which related to notification update change 👀

Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari
Copy link
Member Author

Sorry, I fixed.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot removed the area/web label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (46fd914) 29.97% compared to head (353131c) 29.95%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4557      +/-   ##
==========================================
- Coverage   29.97%   29.95%   -0.03%     
==========================================
  Files         220      220              
  Lines       25851    25873      +22     
==========================================
  Hits         7749     7749              
- Misses      17455    17477      +22     
  Partials      647      647              
Files Changed Coverage Δ
pkg/app/piped/platformprovider/lambda/client.go 4.71% <0.00%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sivchari sivchari changed the title gFix lambda configuration Fix lambda configuration Aug 23, 2023
@sivchari
Copy link
Member Author

OK 👍

@khanhtc1202 khanhtc1202 merged commit b2f85e5 into pipe-cd:master Aug 23, 2023
11 of 13 checks passed
khanhtc1202 pushed a commit that referenced this pull request Aug 24, 2023
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@khanhtc1202 khanhtc1202 mentioned this pull request Aug 24, 2023
khanhtc1202 added a commit that referenced this pull request Aug 24, 2023
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Co-authored-by: sivchari <shibuuuu5@gmail.com>
This was referenced Aug 24, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Aug 27, 2023
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: moko-poi <mokopoi44@gmail.com>
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants