Support create ECS service with serviceRegistries configuration #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4564 +/- ##
==========================================
+ Coverage 29.92% 29.95% +0.02%
==========================================
Files 220 220
Lines 25871 25872 +1
==========================================
+ Hits 7741 7749 +8
+ Misses 17482 17476 -6
+ Partials 648 647 -1
☔ View full report in Codecov by Sentry. |
tokku5552
pushed a commit
to tokku5552/pipecd
that referenced
this pull request
Aug 25, 2023
…-cd#4564) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: 徳田 真之介 <tokuda_shinnosuke@cyberagent.co.jp>
khanhtc1202
added a commit
that referenced
this pull request
Aug 25, 2023
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
added a commit
that referenced
this pull request
Aug 25, 2023
* Support create ECS service with serviceRegistries configuration (#4564) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Support update service which contains serviceRegistries (#4567) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * fix: ECS WaitService finish before task running (#4568) * fix: ECS WaitService finish before task running Signed-off-by: 徳田 真之介 <tokuda_shinnosuke@cyberagent.co.jp> * Update pkg/app/piped/platformprovider/ecs/client.go Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: 徳田 真之介 <tokuda_shinnosuke@cyberagent.co.jp> --------- Signed-off-by: 徳田 真之介 <tokuda_shinnosuke@cyberagent.co.jp> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: 徳田 真之介 <tokuda_shinnosuke@cyberagent.co.jp> Co-authored-by: tokku5552 <69064290+tokku5552@users.noreply.github.com>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Aug 27, 2023
…-cd#4564) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
…-cd#4564) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4386
Does this PR introduce a user-facing change?: