Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECS not remove taskset on quick sync rollback #4580

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Aug 30, 2023

What this PR does / why we need it:

In this PR I did

  • Update rollback traffic routing condition, we only need to revert all traffic to primary target group in case of primary & canary target group config are available (ie. progressive sync)
  • Instead of using clean function in rollback implementation to remove unused taskset, which can only remove CANARY taskset, for general use of rollback function, I use new defined GetServiceTaskSets to get all PRIMARY/ACTIVE tasksets of the current service before rolling back and remove them unused taskset later.
  • Other changes are rearrange function code blocks to make the flow more like ECS deployment.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 8.69% and project coverage change: +0.05% 🎉

Comparison is base (d3e748a) 29.89% compared to head (e814bba) 29.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4580      +/-   ##
==========================================
+ Coverage   29.89%   29.95%   +0.05%     
==========================================
  Files         220      220              
  Lines       25911    25933      +22     
==========================================
+ Hits         7745     7767      +22     
+ Misses      17519    17518       -1     
- Partials      647      648       +1     
Files Changed Coverage Δ
pkg/app/piped/platformprovider/ecs/client.go 0.00% <0.00%> (ø)
pkg/app/piped/platformprovider/ecs/ecs.go 0.00% <ø> (ø)
...kg/app/piped/platformprovider/ecs/target_groups.go 85.71% <100.00%> (+85.71%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬

@khanhtc1202 khanhtc1202 merged commit 5ece2e0 into master Sep 1, 2023
13 of 14 checks passed
@khanhtc1202 khanhtc1202 deleted the fix-ecs-quick-sync-rollback branch September 1, 2023 00:17
khanhtc1202 added a commit that referenced this pull request Sep 1, 2023
* Fix ECS not remove taskset on quick sync rollback (#4580)

* Bump gopkg.in/yaml.v3 in /tool/actions-plan-preview (#4581)

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
Signed-off-by: moko-poi <mokopoi44@gmail.com>
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Nov 5, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants