Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code-Butler #4642

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Add Code-Butler #4642

merged 2 commits into from
Nov 1, 2023

Conversation

ouchi2501
Copy link
Contributor

What this PR does / why we need it:

As discussed below, implementing these changes will enhance the experience of code reviews.
#4636

Which issue(s) this PR fixes:

Refs: #4636

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: uncle <unclesam2501@gmail.com>
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afadde6) 30.53% compared to head (ae61872) 30.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4642      +/-   ##
==========================================
+ Coverage   30.53%   30.55%   +0.02%     
==========================================
  Files         221      221              
  Lines       25937    25937              
==========================================
+ Hits         7919     7925       +6     
+ Misses      17369    17364       -5     
+ Partials      649      648       -1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo
Copy link
Member

ffjlabo commented Nov 1, 2023

@ouchi2501 Thank you for your PR! Let's try it!

@ffjlabo
Copy link
Member

ffjlabo commented Nov 1, 2023

@ouchi2501 plz update branch 🙏

@ouchi2501
Copy link
Contributor Author

@ffjlabo I've updated it.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ouchi2501 ouchi2501 merged commit 3a153c1 into pipe-cd:master Nov 1, 2023
13 checks passed
@ouchi2501 ouchi2501 deleted the add-code-butler branch November 1, 2023 02:38
@ouchi2501
Copy link
Contributor Author

Looks like the error is due to Code-Butler being EnterpriseRepo.
I will investigate.
https://github.com/pipe-cd/pipecd/actions/runs/6715051004

@ouchi2501
Copy link
Contributor Author

/review

2 similar comments
@ouchi2501
Copy link
Contributor Author

/review

@ouchi2501
Copy link
Contributor Author

/review

Copy link

github-actions bot commented Nov 1, 2023

PR Analysis

Main theme

type: Other
description: Adding GitHub workflow for Code Butler

PR summary

type: Other
description: This PR adds a GitHub workflow file for Code Butler, which allows users to interact with the bot through comments in issues.

Type of PR

Refactoring

PR Feedback:

General suggestions

  • The GitHub workflow file looks good overall and meets the requirements for Code Butler. However, it would be helpful to include some documentation in the workflow file to explain how to use the bot and how the workflow works.

Code feedback

  • Relevant file: .github/workflows/code-butler.yaml
  • Suggestion: Add comments to explain the purpose and functionality of each section in the workflow file. This will make it easier for developers to understand and customize the workflow if needed. [important]
  • Relevant line: 3: permissions:

Security concerns:

No

@ouchi2501
Copy link
Contributor Author

I resolved it by adding PipeCD to the list of available GitHub Actions workflows since it seemed to limit the reusable ones.

sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Nov 5, 2023
Signed-off-by: uncle <unclesam2501@gmail.com>
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Feb 12, 2024
Signed-off-by: uncle <unclesam2501@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants