Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @minhquang4334 as a contributor #4707

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Dec 7, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cdf2b8) 30.83% compared to head (deb9617) 30.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4707   +/-   ##
=======================================
  Coverage   30.83%   30.83%           
=======================================
  Files         221      221           
  Lines       25981    25981           
=======================================
  Hits         8012     8012           
  Misses      17319    17319           
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo
Copy link
Member

ffjlabo commented Dec 7, 2023

@t-kikuc
Thanks! Please execute make gen/contributions if you didn't do it? This command adds contributor automatically 👍

@t-kikuc
Copy link
Member Author

t-kikuc commented Dec 7, 2023

@ffjlabo
thank you so much! I'll do it next time

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ffjlabo ffjlabo merged commit f7287c8 into pipe-cd:master Dec 7, 2023
13 checks passed
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Feb 12, 2024
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants