Add reference to the blog that shows how to install control plane on ECS #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka and
t-kikuc
as code owners
|
Added for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4746 +/- ##
==========================================
+ Coverage 30.84% 30.85% +0.01%
==========================================
Files 222 222
Lines 26037 26037
==========================================
+ Hits 8031 8035 +4
+ Misses 17356 17353 -3
+ Partials 650 649 -1 ☔ View full report in Codecov by Sentry. |
ffjlabo
commented
Jan 10, 2024
| Currently, we provide the example of deploying Control Plane to ECS using terraform. | ||
|
|
||
| Please refer to the blog post :) | ||
| [PipeCD best practice 02 - control plane on ECS]({{< ref "/blog/control-plane-on-ecs.md" >}} "PipeCD best practice 02 - control plane on ECS"). |
There was a problem hiding this comment.
Checked whether to work the link and it is OK ✅
ref: https://gohugo.io/content-management/cross-references/#use-of-ref-and-relref
t-kikuc
pushed a commit
that referenced
this pull request
Jan 19, 2024
…ECS (#4746) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
added a commit
that referenced
this pull request
Jan 19, 2024
* Add pipectl init command but not implemented Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Modify init command Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Rename init command to initialize Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Create pipectl int for ECS Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add init for ECS Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Convert json.RawMessage to struct Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Use original structs of ECS for pipectl init Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Init k8s app for pipectl init, but not implemented Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix init input(wip) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add mock prompt reader Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Reractor prompt reader Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Modify mock reader to public Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Refactored prompt reader Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add yaml snapshot test Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Revert "Init k8s app for pipectl init, but not implemented" This reverts commit 4097fb7. Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Refactor pipectl init Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Remove go-yaml from go.mod Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Modify tests to Parallel Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix reference of loop variable in tests Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Enable interruption signal for pipectl init Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add LoadBalancerName to ECS TargetGroup Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Use Reader in tests Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Remove stdinReader Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Remove mockReader Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add Prompt and PromptInput types Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Remove promptReader Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Refactored init,exporter Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Update Copyright Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Refactored nits Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add reference to the blog that shows how to install control plane on ECS (#4746) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Bump follow-redirects from 1.15.2 to 1.15.4 in /web (#4747) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add RC Release Procedure (#4749) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix nits Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix error variable name Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
nnnkkk7
pushed a commit
to nnnkkk7/pipecd
that referenced
this pull request
Feb 1, 2024
…ECS (pipe-cd#4746) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added the link for PipeCD best practice 02 - control plane on ECS
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: