Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipectl plugin installation command by asdf #4756

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

BIwashi
Copy link
Contributor

@BIwashi BIwashi commented Jan 25, 2024

What this PR does / why we need it:
This pull request includes a minor change to the command-line-tool.md documentation file. The change corrects the command for adding the pipectl plugin to asdf. The previous command was incorrect, and the correct command is now provided.

Which issue(s) this PR fixes:
#4755

Does this PR introduce a user-facing change?: no

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@BIwashi BIwashi marked this pull request as ready for review January 25, 2024 05:11
@ffjlabo
Copy link
Member

ffjlabo commented Jan 25, 2024

Thank you for the contribution!
plz signoff the commit 🙏
git commit -s

@ffjlabo
Copy link
Member

ffjlabo commented Jan 25, 2024

@BIwashi
the details↓ 🙏
https://github.com/pipe-cd/pipecd/blob/master/CONTRIBUTING.md#contributor-license-agreement

Signed-off-by: Shota Iwami <saxo-folatre1129@outlook.jp>
@BIwashi BIwashi force-pushed the fix-docs-asdf-pipectl-add-plugin branch from 887ef22 to 7a3e1e9 Compare January 25, 2024 05:16
@ffjlabo ffjlabo enabled auto-merge (squash) January 25, 2024 05:19
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0189b18) 31.06% compared to head (7a3e1e9) 31.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4756   +/-   ##
=======================================
  Coverage   31.06%   31.06%           
=======================================
  Files         225      225           
  Lines       26257    26257           
=======================================
  Hits         8156     8156           
  Misses      17451    17451           
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🚀

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!

@ffjlabo ffjlabo merged commit 8e302a8 into pipe-cd:master Jan 25, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants