Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a param to run/piped in Makefile for setting --log-encoding to run the piped with specific log format #4762

Merged

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Jan 29, 2024

What this PR does / why we need it:
Add a param to run/piped in Makefile for setting --log-encoding to run the piped with a specific log format.
We can choose 3 formats

	a.rootCmd.PersistentFlags().StringVar(
		&a.telemetryFlags.LogEncoding,
		"log-encoding",
		a.telemetryFlags.LogEncoding,
		"The encoding type for logger [json|console|humanize].",
	)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

…n the piped with specific log format

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e302a8) 31.04% compared to head (dedf3c5) 31.03%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4762      +/-   ##
==========================================
- Coverage   31.04%   31.03%   -0.01%     
==========================================
  Files         225      225              
  Lines       26257    26257              
==========================================
- Hits         8152     8150       -2     
- Misses      17455    17457       +2     
  Partials      650      650              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@ffjlabo ffjlabo enabled auto-merge (squash) January 29, 2024 08:03
@ffjlabo ffjlabo requested a review from t-kikuc January 29, 2024 08:03
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@ffjlabo ffjlabo merged commit 3c72f4a into master Jan 29, 2024
13 of 14 checks passed
@ffjlabo ffjlabo deleted the add-log-encoding-param-for-running-piped-with-Makefile branch January 29, 2024 08:13
t-kikuc pushed a commit that referenced this pull request Feb 2, 2024
…n the piped with specific log format (#4762)

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants