Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix indents of the pprof page #4776

Merged
merged 12 commits into from
Feb 20, 2024
Merged

[doc] Fix indents of the pprof page #4776

merged 12 commits into from
Feb 20, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Feb 6, 2024

What this PR does / why we need it:

  • Fix indents of the procedures

    • especially, 2. Get the Cpi Profile was merged with the previous line.

    image

  • Add one 'a'

Which issue(s) this PR fixes: no

Does this PR introduce a user-facing change?: no

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@khanhtc1202
Copy link
Member

Screenshot 2024-02-06 at 11 58 23

some tabs mixes with spaces @t-kikuc

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f688a36) 31.04% compared to head (9080d67) 31.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4776   +/-   ##
=======================================
  Coverage   31.04%   31.04%           
=======================================
  Files         225      225           
  Lines       26353    26353           
=======================================
  Hits         8182     8182           
  Misses      17518    17518           
  Partials      653      653           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc
Copy link
Member Author

t-kikuc commented Feb 6, 2024

Screenshot 2024-02-06 at 11 58 23 some tabs mixes with spaces @t-kikuc

Thanks, I fixed it

@ffjlabo
Copy link
Member

ffjlabo commented Feb 14, 2024

@t-kikuc Is this still miexd?
_doc__Fix_indents_of_the_pprof_page_by_t-kikuc_·_Pull_Request__4776_·_pipe-cd_pipecd

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
…ix-indent-pprof

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc
Copy link
Member Author

t-kikuc commented Feb 16, 2024

Sorry, I fixed. (by removing the last line)

Besides, I fixed the doc of v0.46.x too.

@t-kikuc t-kikuc enabled auto-merge (squash) February 16, 2024 01:33
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202
Copy link
Member

@ffjlabo Please

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc t-kikuc merged commit 4f57ec5 into master Feb 20, 2024
14 checks passed
@t-kikuc t-kikuc deleted the doc-fix-indent-pprof branch February 20, 2024 05:42
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
@t-kikuc t-kikuc mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants