Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adding new environment #97

Merged
merged 3 commits into from Jun 19, 2020
Merged

Implement adding new environment #97

merged 3 commits into from Jun 19, 2020

Conversation

stormcat24
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@@ -96,6 +96,8 @@ message ListPipedsResponse {
}

message AddEnvironmentRequest {
string name = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be required.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 25.65%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jun 19, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 1dce1db into master Jun 19, 2020
@pipecd-bot pipecd-bot deleted the add-environment branch June 19, 2020 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants