Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeagueSocket deletes "log.txt" file on init. #2

Open
kennipj opened this issue Jul 19, 2020 · 0 comments
Open

LeagueSocket deletes "log.txt" file on init. #2

kennipj opened this issue Jul 19, 2020 · 0 comments

Comments

@kennipj
Copy link

kennipj commented Jul 19, 2020

As far as I've seen the library doesnt output to log.txt anywhere, but in the constructor for LeagueSocket you delete log.txt if it exists. If it is being used somewhere, consider using a less-general name, as the current name can cause quite a bit confusion, when the file is just deleted all of a sudden.

See https://github.com/pipe01/LCU.NET/blob/master/LeagueSocket.cs#L92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant