Add CodeQL #1
Add CodeQL #1
Conversation
| id: init_codeql | ||
| uses: github/codeql-action/init@v1 | ||
| # with: | ||
| # queries: security-and-quality |
There was a problem hiding this comment.
I was working on the building process and by mistake i left it commented.
| uses: actions/cache@v1.1.2 | ||
| with: | ||
| path: Build/WinMergeDownloadDeps | ||
| key: WinMergeDownloadDeps |
There was a problem hiding this comment.
- Why is this step required for the CQL pipeline ?
- The name is not good enough.
- What is "chache" ?
There was a problem hiding this comment.
actions/cache action allows caching dependencies and build outputs to improve workflow execution time.
| id: build | ||
| run: | | ||
| .\DownloadDeps.cmd | ||
| .\BuildAll.vs2019.cmd x64 -ci |
There was a problem hiding this comment.
Name and ID are not good enough. Should've checked out the names and IDs of the other steps, to use them as examples.
|
|
||
| jobs: | ||
| analyze: | ||
| name: CodeQL Analysis |
There was a problem hiding this comment.
Change the name of the job from "CodeQL Analysis" to "Analyze".
Change it in your template as well and I will in mine, too.
| jobs: | ||
| analyze: | ||
| name: Analyze | ||
| runs-on: windows-latest |
There was a problem hiding this comment.
Why windows not ubuntu ?
Also you haven't resolved the last changes request.
There was a problem hiding this comment.
@aleks-ivanov
I am using windows because the .cmd file cannot be built on ubuntu.
Resolved the last requested changes.
…into feature/codeql
| jobs: | ||
| analyze: | ||
| name: Analyze | ||
| runs-on: windows-latest |
No description provided.