New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use %v instead of %w in log.Fatalf calls #2

Closed

josharian opened this issue Nov 8, 2019 · 0 comments · Fixed by #3

josharian commented Nov 8, 2019

In many places in this repo, there's code like this:

    log.Fatalf("failed to open mp3 file: %w", err)

When it triggers, the output will be ugly, since log.Fatalf doesn't understand the %w verb. They should be changed back to %v.

Related: golang/go#35472

dudk mentioned this issue

Remove errors wrapping from fmt.Fatalf calls #3

Merged

dudk closed this as completed in #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment