Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Ruby add sast stage #126

Merged
merged 4 commits into from Jan 4, 2022
Merged

Feat: Ruby add sast stage #126

merged 4 commits into from Jan 4, 2022

Conversation

lilianeconstantino
Copy link
Contributor

@lilianeconstantino lilianeconstantino commented Dec 23, 2021

Added a SAST (Static application security testing) stage for Ruby. In pipelinit, semgrep is the tool used for static analysis.

Resolves: #125

To test:
In a GitHub repository with a ruby file, create a pull request of a branch. See the tests performed also in the Action tab.

We get this on GitHub PR:
test2-sast by lilianeconstantino · Pull Request #2 · lilianeconstantino_spec - Google Chrome 29_12_2021 14_31_17 (2)

And this on GitHub Actions:
test-sast · lilianeconstantino_spec@b1f887e - Google Chrome 28_12_2021 15_58_42 (3)

Copy link
Collaborator

@oesgalha oesgalha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilianeconstantino I've update the #125 description to build a SAST stage more similar to other stacks (prefer the owasp-top-ten to web apps).

Can you check it out and update this PR? Sorry for the inconvenience.

Copy link
Collaborator

@oesgalha oesgalha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👏

Just one note:
You've included a new sample project, but the test is missing. Can you add it in the default_test.ts file?

@lilianeconstantino lilianeconstantino force-pushed the feat/125-add-sast-stage branch 2 times, most recently from f8d23a1 to c5eff3f Compare January 3, 2022 19:51
@oesgalha oesgalha merged commit 82be558 into main Jan 4, 2022
@oesgalha oesgalha deleted the feat/125-add-sast-stage branch January 4, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby: Add SAST stage
3 participants