feat(settings): add helper methods to get list of float or double

pippo-java · Jan 13, 2018 · a586b3d · a586b3d
1 parent 2ac1852
commit a586b3d
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 2 deletions.
diff --git a/pippo-core/src/main/java/ro/pippo/core/PippoSettings.java b/pippo-core/src/main/java/ro/pippo/core/PippoSettings.java
@@ -640,7 +640,7 @@ public List<String> getStrings(String name, String delimiter) {
      * Returns a list of comma-delimited integers from the specified name.
      *
      * @param name
-     * @return list of strings
+     * @return list of integers
      */
     public List<Integer> getIntegers(String name) {
         return getIntegers(name, DEFAULT_LIST_DELIMITER);
@@ -672,7 +672,7 @@ public List<Integer> getIntegers(String name, String delimiter) {
      * Returns a list of comma-delimited longs from the specified name.
      *
      * @param name
-     * @return list of strings
+     * @return list of longs
      */
     public List<Long> getLongs(String name) {
         return getLongs(name, DEFAULT_LIST_DELIMITER);
@@ -700,6 +700,68 @@ public List<Long> getLongs(String name, String delimiter) {
         return Collections.unmodifiableList(longs);
     }
 
+    /**
+     * Returns a list of comma-delimited floats from the specified name.
+     *
+     * @param name
+     * @return list of floats
+     */
+    public List<Float> getFloats(String name) {
+        return getFloats(name, DEFAULT_LIST_DELIMITER);
+    }
+
+    /**
+     * Returns a list of floats from the specified name using the specified delimiter.
+     *
+     * @param name
+     * @param delimiter
+     * @return list of floats
+     */
+    public List<Float> getFloats(String name, String delimiter) {
+        List<String> strings = getStrings(name, delimiter);
+
+        List<Float> floats = new ArrayList<>(strings.size());
+        for (String value : strings) {
+            try {
+                float i = Float.parseFloat(value);
+                floats.add(i);
+            } catch (NumberFormatException e) {
+            }
+        }
+        return Collections.unmodifiableList(floats);
+    }
+
+    /**
+     * Returns a list of comma-delimited doubles from the specified name.
+     *
+     * @param name
+     * @return list of doubles
+     */
+    public List<Double> getDoubles(String name) {
+        return getDoubles(name, DEFAULT_LIST_DELIMITER);
+    }
+
+    /**
+     * Returns a list of doubles from the specified name using the specified delimiter.
+     *
+     * @param name
+     * @param delimiter
+     * @return list of doubles
+     */
+    public List<Double> getDoubles(String name, String delimiter) {
+        List<String> strings = getStrings(name, delimiter);
+
+        List<Double> doubles = new ArrayList<>(strings.size());
+        for (String value : strings) {
+            try {
+                double i = Double.parseDouble(value);
+                doubles.add(i);
+            } catch (NumberFormatException e) {
+            }
+        }
+        return Collections.unmodifiableList(doubles);
+    }
+
     /**
      * Gets the duration setting and converts it to milliseconds.
      * <p/>

diff --git a/pippo-core/src/test/java/ro/pippo/core/PippoSettingsTest.java b/pippo-core/src/test/java/ro/pippo/core/PippoSettingsTest.java
@@ -62,6 +62,22 @@ public void testGetIntegers() {
         assertTrue(values.isEmpty());
     }
 
+    @Test
+    public void testGetDoubles() {
+        // tests would similar for getFloats(String, String)
+        Mockito.doReturn(" [1234, 123, value3]").when(pippoSettings)
+            .getString("key", null);
+        Mockito.doCallRealMethod().when(pippoSettings).getStrings("key", ",");
+        Mockito.doCallRealMethod().when(pippoSettings).getDoubles("key", ",");
+
+        List<Double> values = pippoSettings.getDoubles("key", ",");
+        assertEquals(Arrays.asList(1234d, 123d), values);
+
+        Mockito.doReturn(Collections.emptyList()).when(pippoSettings).getStrings("key", ",");
+        values = pippoSettings.getDoubles("key", ",");
+        assertTrue(values.isEmpty());
+    }
+
     @Test
     public void testGetNumber() {
         Mockito.doReturn(" 1234").when(pippoSettings).getString("key", null);