refactor: use early returns

piqnt · Aug 4, 2023 · 65eaf4d · 65eaf4d
1 parent c76525b
commit 65eaf4d
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 49 deletions.
diff --git a/src/dynamics/joint/MouseJoint.ts b/src/dynamics/joint/MouseJoint.ts
@@ -194,10 +194,9 @@ export class MouseJoint extends Joint {
    * Use this to update the target point.
    */
   setTarget(target: Vec2Value): void {
-    if (!Vec2.areEqual(target, this.m_targetA)) {
-      this.m_bodyB.setAwake(true);
-      this.m_targetA = Vec2.clone(target);
-    }
+    if (Vec2.areEqual(target, this.m_targetA)) return;
+    this.m_bodyB.setAwake(true);
+    this.m_targetA = Vec2.clone(target);
   }
 
   getTarget(): Vec2 {

diff --git a/src/dynamics/joint/PrismaticJoint.ts b/src/dynamics/joint/PrismaticJoint.ts
@@ -449,33 +449,30 @@ export class PrismaticJoint extends Joint {
    * Enable/disable the joint motor.
    */
   enableMotor(flag: boolean): void {
-    if (flag != this.m_enableMotor) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_enableMotor = flag;
-    }
+    if (flag == this.m_enableMotor) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_enableMotor = flag;
   }
 
   /**
    * Set the motor speed, usually in meters per second.
    */
   setMotorSpeed(speed: number): void {
-    if (speed != this.m_motorSpeed) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_motorSpeed = speed;
-    }
+    if (speed == this.m_motorSpeed) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_motorSpeed = speed;
   }
 
   /**
    * Set the maximum motor force, usually in N.
    */
   setMaxMotorForce(force: number): void {
-    if (force != this.m_maxMotorForce) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_maxMotorForce = force;
-    }
+    if (force == this.m_maxMotorForce) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_maxMotorForce = force;
   }
 
   getMaxMotorForce(): number {

diff --git a/src/dynamics/joint/RevoluteJoint.ts b/src/dynamics/joint/RevoluteJoint.ts
@@ -302,11 +302,10 @@ export class RevoluteJoint extends Joint {
    * Enable/disable the joint motor.
    */
   enableMotor(flag: boolean): void {
-    if (flag != this.m_enableMotor) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_enableMotor = flag;
-    }
+    if (flag == this.m_enableMotor) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_enableMotor = flag;
   }
 
   /**
@@ -320,11 +319,10 @@ export class RevoluteJoint extends Joint {
    * Set the motor speed in radians per second.
    */
   setMotorSpeed(speed: number): void {
-    if (speed != this.m_motorSpeed) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_motorSpeed = speed;
-    }
+    if (speed == this.m_motorSpeed) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_motorSpeed = speed;
   }
 
   /**
@@ -338,11 +336,10 @@ export class RevoluteJoint extends Joint {
    * Set the maximum motor torque, usually in N-m.
    */
   setMaxMotorTorque(torque: number): void {
-    if (torque != this.m_maxMotorTorque) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_maxMotorTorque = torque;
-    }
+    if (torque == this.m_maxMotorTorque) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_maxMotorTorque = torque;
   }
 
   getMaxMotorTorque(): number {

diff --git a/src/dynamics/joint/WheelJoint.ts b/src/dynamics/joint/WheelJoint.ts
@@ -314,22 +314,20 @@ export class WheelJoint extends Joint {
    * Enable/disable the joint motor.
    */
   enableMotor(flag: boolean): void {
-    if (flag != this.m_enableMotor) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_enableMotor = flag;
-    }
+    if (flag == this.m_enableMotor) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_enableMotor = flag;
   }
 
   /**
    * Set the motor speed, usually in radians per second.
    */
   setMotorSpeed(speed: number): void {
-    if (speed != this.m_motorSpeed) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_motorSpeed = speed;
-    }
+    if (speed == this.m_motorSpeed) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_motorSpeed = speed;
   }
 
   /**
@@ -343,11 +341,10 @@ export class WheelJoint extends Joint {
    * Set/Get the maximum motor force, usually in N-m.
    */
   setMaxMotorTorque(torque: number): void {
-    if (torque != this.m_maxMotorTorque) {
-      this.m_bodyA.setAwake(true);
-      this.m_bodyB.setAwake(true);
-      this.m_maxMotorTorque = torque;
-    }
+    if (torque == this.m_maxMotorTorque) return;
+    this.m_bodyA.setAwake(true);
+    this.m_bodyB.setAwake(true);
+    this.m_maxMotorTorque = torque;
   }
 
   getMaxMotorTorque(): number {