Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break down index.d.ts to smaller files #66

Merged
merged 9 commits into from
Sep 20, 2018
Merged

Break down index.d.ts to smaller files #66

merged 9 commits into from
Sep 20, 2018

Conversation

shakiba
Copy link
Collaborator

@shakiba shakiba commented Sep 9, 2018

also adding tslint

@shakiba shakiba requested a review from zOadT September 9, 2018 21:59
@shakiba
Copy link
Collaborator Author

shakiba commented Sep 9, 2018

I have not figured out how to link them yet!

Copy link
Collaborator

@zOadT zOadT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I also planned to split the definitions at some point. Currently I can't test it, but I think one of these directives are the way to go here.
If the directives don't work you can maybe check whether you can set the types field in package.json to an array of files or to an folder, but this would be quite ugly. (I don't think this works anyway.)

BTW: Feel free to add youself to the authors! :)

lib/index.d.ts Outdated
*/

declare namespace plancck {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@@ -0,0 +1,90 @@
// Definitions by: Oliver Zell <https://github.com/zOadT>
// TypeScript Version: 3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally kept the old header here.

@zOadT
Copy link
Collaborator

zOadT commented Sep 17, 2018

To resolve the confict you can just keep the version of this branch, the definition of AABB is up to date.

@shakiba
Copy link
Collaborator Author

shakiba commented Sep 20, 2018

Thanks @zOadT! I rebased the branch and solved the conflict. Is there anything else I need to do? If not please feel free to merge it.

@zOadT zOadT merged commit 1d3b5bd into master Sep 20, 2018
@zOadT zOadT deleted the smaller-ts-files branch September 21, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants