-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break down index.d.ts to smaller files #66
Conversation
I have not figured out how to link them yet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I also planned to split the definitions at some point. Currently I can't test it, but I think one of these directives are the way to go here.
If the directives don't work you can maybe check whether you can set the types
field in package.json
to an array of files or to an folder, but this would be quite ugly. (I don't think this works anyway.)
BTW: Feel free to add youself to the authors! :)
lib/index.d.ts
Outdated
*/ | ||
|
||
declare namespace plancck { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
testbed/index.d.ts
Outdated
@@ -0,0 +1,90 @@ | |||
// Definitions by: Oliver Zell <https://github.com/zOadT> | |||
// TypeScript Version: 3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You accidentally kept the old header here.
To resolve the confict you can just keep the version of this branch, the definition of |
Fixed in v0.2.2
b701d6d
to
226b455
Compare
Thanks @zOadT! I rebased the branch and solved the conflict. Is there anything else I need to do? If not please feel free to merge it. |
also adding tslint