Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to configure Pod's hostNetwork, dnsConfig, dnsPolicy #41

Conversation

druchoo
Copy link
Contributor

@druchoo druchoo commented Nov 23, 2023

Hello, thank you for snapshot-controller Chart. Please review for AWS EKS with custom CNI compatibility. Fixes #42


When using a custom CNI (such as Weave or Calico) on Amazon EKS, the webhook cannot be reached.

Internal error occurred: failed calling webhook "snapshot-validation-webhook.snapshot.storage.k8s.io": failed to call webhook: Post "https://snapshot-validation-webhook.kube-system.svc:443/volumesnapshot?timeout=2s": Address is not allowed

This happens because the control plane cannot be configured to run on a custom CNI on EKS, so the CNIs
differ between control plane and worker nodes.

To address this, the webhook can be run in the host network so it can be reached.

webhook:
  hostNetwork: true
  dnsPolicy: ClusterFirstWithHostNet

@druchoo druchoo force-pushed the feature/snapshot-controller/hostNetwork branch 3 times, most recently from 24d507a to b8744bd Compare November 23, 2023 21:00
Copy link
Member

@WanzenBug WanzenBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some simplification on the templates, otherwise I'm ready to merge this.

As a side note, I was under the impression that EKS clusters already have the snapshot controller deployed from the start.

Signed-off-by: Andrew Choo <achoo04@gmail.com>
@druchoo druchoo force-pushed the feature/snapshot-controller/hostNetwork branch from b8744bd to 43b78f2 Compare November 24, 2023 14:56
Copy link
Member

@WanzenBug WanzenBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WanzenBug WanzenBug merged commit 3da67a8 into piraeusdatastore:main Nov 27, 2023
1 check passed
@druchoo druchoo deleted the feature/snapshot-controller/hostNetwork branch November 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set webhook pod's hostNetwork for Amazon EKS
2 participants