Use controller-gen instead of operator-sdk #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
reviewed
Mar 1, 2022
|
Also, as a general heads-up, I won't merge this for 1.8.0 |
kvaps
force-pushed
the
controller-gen
branch
2 times, most recently
from
279f2f1
to
c7e5232
Compare
Merged
|
@kvaps I think you need to update the github actions to use go 1.17 |
kvaps
force-pushed
the
controller-gen
branch
2 times, most recently
from
2432c64
to
b161102
Compare
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
WanzenBug
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator-sdk v0.19.4 is quite old and already deprecated, as it generates resources wrong.
I just tried to implement
podTemplatefield and it wasn't working for Kubernetes >1.18see kubernetes/kubernetes#91395
controller-gen which is used by default in newer operator-sdk versions is working fine.