Implement multi-arch build for piraeus-client #76
Conversation
| make update | ||
| . ./VERSION.env | ||
|
|
||
| TAGS="${DOCKERHUB_IMAGAE}:${LINSTOR_CLIENT_VERSION},${DOCKERHUB_IMAGAE}:${SHORT_VERSION}",${DOCKERHUB_IMAGAE}:latest,${QUAYIO_IMAGE}:${LINSTOR_CLIENT_VERSION},${QUAYIO_IMAGE}:${SHORT_VERSION}",${QUAYIO_IMAGE}:latest" |
There was a problem hiding this comment.
Could probably clean this up
| run: | | ||
| DOCKERHUB_IMAGAE=docker.io/${{ secrets.DOCKERHUB_USERNAME }}/piraeus-client |
|
I saw this got some force pushes. So I suggest you get it into a state you are satisfied with and then please squash the commits, this does not need to be a series. Then I'd suggest you add myself as reviewer and assign @WanzenBug , he did the CI/workflow work. |
Signed-off-by: Jukie <isaac.wilson514@gmail.com> Fix image tags Signed-off-by: Jukie <isaac.wilson514@gmail.com> Add build context to buildx Signed-off-by: Jukie <isaac.wilson514@gmail.com> Add build-args for package versions Signed-off-by: Jukie <isaac.wilson514@gmail.com>
|
Apologies for the delay here. Will finish my updates today. |
That was 15 days ago. Do you still intend to work in this? |
|
Hey, I would like to take this over (no idea what I'm getting in to). Is there a way for me to highjack this PR with my own branch or should I create a new one? |
I'd say just create a new branch/MR and state in the description that this supersedes this one |
|
Wilco |
|
Closing this one, see #84 |
Closes #74
I didn't remove the Makefile with this PR in case that's used elsewhere. If it isn't we should be able to drop it.