Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2022 Project Update #407

Merged
merged 7 commits into from Jul 5, 2022
Merged

2022 Project Update #407

merged 7 commits into from Jul 5, 2022

Conversation

TheLQ
Copy link
Member

@TheLQ TheLQ commented Jul 3, 2022 •
edited

Please approve @hoerup and @Cypherke . Thank you for your significant contributions to this project. More PRs to follow in the next weeks fixing bugs. Then we can fix #403 .

  • In AUTHORS, list maintainers. Replace all copyright/@author/etc with The PircBotX Project Authors. This has been a team project

  • In README

    • Improved project description
    • Expanded feature list to everything
    • Cleanup old headers
    • Cleanup license section
    • Improved wording

  • In POM

    • Refactored for Maven's 2022 ecosystem
    • Updated all build dependencies
    • Support reproducible builds. One benifit is mvn site no longer updates a timestamp in every single file

  • Release Management

    • Create dedicated release signing key in src/etc/release-key.gpg
    • Revert Maven package group to original org.pircbotx for independence reasons. Recently bought pircbotx.org for 10 years.
    • I nominate @hoerup to share with my Sonatype OSSRH account, new private key, and domain registrar account to reduce our bus factor. Just be mindful of supply chain attacks.
    • Leave new jitpack.io repo alone for now to avoid duplicate repos
    • Replace Travis CI (RIP) with Github Actions

  • Deploy 2.2 to Maven Central Prod

    • Compared 
      mkdir jitpack maven
cd jitpack
wget \
    https://jitpack.io/com/github/pircbotx/pircbotx/2.2/pircbotx-2.2.pom \
    https://jitpack.io/com/github/pircbotx/pircbotx/2.2/pircbotx-2.2.jar
sha256sum * | tee ../hashes.txt
# 28f301520ca8ac12099f31acb64de92cc084253f691fc8a2fd165660da82bd77  pircbotx-2.2.pom
# 004b6f46666f8b256a786b63ffc070afca77ce59938e34ef3fd76bfabc851ab9  pircbotx-2.2.jar

cd ../maven
wget $someStagingUrlTODO
sha256sum -c ../hashes.txt
# pircbotx-2.2.jart: OK

PircBotX turns 12 soon. My first commit was August 2010 as a High School Senior.

@TheLQ
Update project authors
055c912
@TheLQ
Improve README project description and feature list. Remove old sections
b137ba6
@TheLQ
Refactor and modernize pom for site and deploy goals. Changes:
adc4437 
maven-compiler-plugin uses release CLI option now
Remove unsupported plugin options
Move jacoco to profile since it was breaking unit tests
Removed cobertura it's unmaintained for >jdk8
Fix javadoc generation

Replace unsupported <prerequisites> with enforcer
Use modern <reporting> section
Remove wagon-scm we now manually deploy with gh-pages

reformat with intellij
@TheLQ
Bump actual project dependencies
84cc2c1
@TheLQ
Switch to sonatype deploy plugin, reproducible builds
2081b4b
@TheLQ
Delete old hg repo files
0bbbc5c
@TheLQ
Switch to Github Actions and plugins, reproducible jars
6f78075
@TheLQ
Copy link
Member Author

TheLQ commented Jul 3, 2022

Been sitting on this for a while blocked on the release and gpg task. Will just merge what's done instead.

@hoerup hoerup self-requested a review July 3, 2022 11:30
hoerup
hoerup approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@hoerup hoerup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

tobciu
tobciu approved these changes Jul 3, 2022
View reviewed changes
Copy link

@tobciu tobciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hoerup hoerup merged commit 38a4710 into master Jul 5, 2022
@Cypherke
Copy link
Member

sorry was on a vacation... very nice change. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoerup hoerup hoerup approved these changes

@tobciu tobciu tobciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No more proper releases?
4 participants
@TheLQ @Cypherke @hoerup @tobciu