Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LASTCOMMITDATETIME #36

Merged
merged 4 commits into from Oct 6, 2019
Merged

Conversation

tartinesKiller
Copy link
Contributor

Including docs and tests.

@bencoveney
Copy link

I am in no way a maintainer but FWIW I've taken a look and the only think I'd mention is that when adding the branch info it was requested to be behind a flag:

We should keep the branch file creation behind a flag (branch: true) so that we can release it as a minor version. It should have the default value as false.

Thanks for the feature (and thanks to the maintainers) - This change would be super useful for me.

@pirelenito
Copy link
Owner

Thanks for the PR @tartinesKiller, and thanks @bencoveney for the review.

Indeed it looks great! As I mentioned in #46 I'll be doing some housekeeping soon in this project and hopefully get your PR merged.

One year is way too long time to wait. So I'm sorry for that.

Thanks a bunch for your understanding. ❤️

@pirelenito pirelenito merged commit 1283cb7 into pirelenito:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants