This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Extra algorithm to support VINs returning special chars #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra tests: http://goo.gl/QuLlY6 Possible fix for: pires/android-obd-reader#174
|
Why don't you add a test for this as well? |
|
I think that is a good idea. But do not merge yet please. As it has not solved the users issue |
|
Okay this did manage to solve my issue and the users issue #174. I just want to simplify the code and try and add additional test case. |
This replaces the old algorithm for the CAN protocol, also removes redundant replace .replaceAll("[\u0000-\u001f]", "") since the new algorithm takes care of it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra tests: http://goo.gl/QuLlY6
Possible fix for: pires/android-obd-reader#174