Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%DESCRIPTION% not working #12

Closed
DavidMcRitchie opened this issue Jul 27, 2020 · 2 comments
Closed

%DESCRIPTION% not working #12

DavidMcRitchie opened this issue Jul 27, 2020 · 2 comments

Comments

@DavidMcRitchie
Copy link

Short description

Was failing with error codes now have a mixture of returning nothing or error codes

Steps to reproduce

Test1 %URL%

https://mail.aol.com/webmail-std/en-us/suite
https://github.com/piroor/copy-selected-tabs-to-clipboard/labels
view-source:https://github.com/piroor/copy-selected-tabs-to-clipboard/labels
about:addons

Test2 %description%123%DESCRIPTION%345%TITLE%678%EOF%

123345AOL Mail (5333)678%EOF%
123345Issues · piroor/copy-selected-tabs-to-clipboard · GitHub678%EOF%
123345https://github.com/piroor/copy-selected-tabs-to-clipboard/labels678%EOF%
123345Add-ons Manager678%EOF%\

HTML Link with Description
%TITLE_HTML%

and added another tab and retested
http://dmcritchie.mvps.org/dolphin/lesson_from_newtab.htm

params.tab is undefined
fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1
fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

Issues · piroor/copy-selected-tabs-to-clipboard · GitHub
https://github.com/piroor/copy-selected-tabs-to-clipboard/labels
Add-ons Manager
params.tab is undefined
fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1
fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

Expected result

A good link to go into an HTML file or to paste into an RTF document

Bookmarklets, history, exported bookmarks, extensions for Chrome (2020-07-25)

Actual result

Results shown above

Environment

  • Platform (OS): Windows 10 on ASUS T100TA
  • Version of Firefox: 78.0.2
    *Version of Copy Selected Tabs to Clipboard: 1.3.0
  • Version (or revision) of Multiple Tab Handler: didn't see requirement for MTH (not installed),
    Enabled 3.1.3

Results still the same)

params.tab is undefined
fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1
fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

params.tab is undefined
fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1
fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

https://github.com/piroor/copy-selected-tabs-to-clipboard/labels
Add-ons Manager
params.tab is undefined
fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1
fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

piroor added a commit that referenced this issue Jul 27, 2020
@piroor
Copy link
Owner

piroor commented Jul 27, 2020

Thanks! The commit df63426 should fix this.

@piroor piroor closed this as completed Jul 27, 2020
@DavidMcRitchie
Copy link
Author

Thanks Piro, just came back to try to make the pattern show up better and it is already solved/closed.

Love the tools for keeping track of changes in github (like archive.org, and wikipedia.org), and the fix shows me how shortened words are official as the examples didn't exactly match definitions.

The whole process is a lot better than using email or newsgroup as we had done before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants