Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set real minimum thumbnail size in options dialog #3

Merged
merged 1 commit into from
May 28, 2013

Conversation

Infocatcher
Copy link
Contributor

I think, we can do it without try/catch – it's safe to get error here.

I think, we can do it without try/catch – it's safe to get error here.
piroor added a commit that referenced this pull request May 28, 2013
Set real minimum thumbnail size in options dialog
@piroor piroor merged commit 3d9d9f4 into piroor:master May 28, 2013
@piroor
Copy link
Owner

piroor commented May 28, 2013

Oh, thanks! I missed this request.

@piroor
Copy link
Owner

piroor commented May 28, 2013

Oops, I misread... The text box is just for "maximum size of flexible thumbnail", not for "minimum". I've reverted it...

@Infocatcher
Copy link
Contributor Author

Oops, I misread... The text box is just for "maximum size of flexible thumbnail", not for "minimum". I've reverted it...

Hmm... this is .setAttribute('min', thumbnailMinSize).
Anyway, the real reason is hardcoded minimum thumbnail size: we can set anything in options, but will be used only 26px and larger. So, #4 is also related to this issue.

@piroor
Copy link
Owner

piroor commented May 28, 2013

OK, sorry, I reintroduced this patch! I've been haste...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants