Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Options for Tree Style Tab #7

Open
sumyungguy opened this issue Jun 25, 2017 · 0 comments
Open

[feature request] Options for Tree Style Tab #7

sumyungguy opened this issue Jun 25, 2017 · 0 comments

Comments

@sumyungguy
Copy link

sumyungguy commented Jun 25, 2017

As mentioned in piroor/treestyletab#1083, in the past Tree Style Tab opened bookmarks following TST's new blank tab preference, but it doesn't anymore. Since control of tab placement from bookmarks was marked "out of purpose" for TST, I'd like to add a request for it here.

Piro, I understand you are very busy and probably won't have time for this, but I thought to add it anyway, because maybe it's a good idea, or maybe there's a better idea. I looked at the source code to see if there was a simple way to modify it, but I'm not so good in Javascript and I couldn't figure it out.

I have three suggestions, in order of amount of work:

  1. Detect if Tree Style Tab is installed, and if so, open the bookmark according to the "new blank tab" preference of TST. There could be an option to disable this.

  2. It's own preference to choose where to open a bookmark (independent, child, sibling, or next sibling). When the user has chosen one of the TST options, but doesn't have TST installed, it would default to independent.

Would it be possible to use extensions.openbookmarkintab.place, like this?
kPLACE_CURRENT : 0,
kPLACE_NEW_TAB : 1,
kPLACE_NEW_WINDOW : 2,
kPLACE_TST_CHILD : 3,
kPLACE_TST_SIBLING : 4,
kPLACE_TST_NEXT_SIBLING: 5,
kPLACE_IN_BACKGROUND : 256,

  1. As above but add UI to Preferences window: add radio buttons for:
    "Open Bookmarks In:"
  • New Tab
  • New Window
  • Child Tab (requires TST)
  • Sibling Tab (requires TST)
  • Next Sibling Tab (requires TST)
  1. Deluxe version :-) Preferences window could be similar to TST "New Tabs" preferences, with menus. This way you could customize also the middle-click behavior:

Open bookmark as:

  • the current tab (Firefox default)
  • an independent tab
    [the following would become available when TST is installed:]
  • a child of the current tab
  • a sibling of the current tab
  • the next sibling of the current tab

For middle-click on bookmark, open bookmark as:

  • the current tab (Firefox default)
  • an independent tab
    [the following would become available when TST is installed:]
  • a child of the current tab
  • a sibling of the current tab
  • the next sibling of the current tab

Thanks for considering this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant