Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The TST sidebar keeps reloading #1818

Closed
ksze opened this issue Mar 7, 2018 · 12 comments
Closed

The TST sidebar keeps reloading #1818

ksze opened this issue Mar 7, 2018 · 12 comments

Comments

@ksze
Copy link

ksze commented Mar 7, 2018

Short description

The TST sidebar keeps reloading

Steps to reproduce

  1. Update TST from 2.4.16 to 2.4.17

Expected result

TST runs stably.

Actual result

TST keeps reloading the sidebar.

Environment

  • Platform (OS): macOS High Sierra 10.13.3
  • Version of Firefox: 58.0.2 64-bit
  • Version (or revision) of Tree Style Tab: 2.4.16
@azizLIGHT
Copy link

I think you might be talking about #1812

@ksze
Copy link
Author

ksze commented Mar 7, 2018

@azizLIGHT My symptoms are a bit different, I think. My sidebar does display, with the tabs; It's just that the sidebar keeps reloading after displaying the tabs, so it cycles from the animated blob, to showing tabs, to showing the animated blob again, and keeps repeating like that.

@azizLIGHT
Copy link

@ksze Oh yeah that is different. The issue I linked just reloads the sidebar forever without any glimpse of the tabs. Sorry!

@volas
Copy link

volas commented Mar 7, 2018

Same problem

@AVHon
Copy link

AVHon commented Mar 7, 2018

I also started having this problem. I fixed it with the reverse solution that @mr-brunes used for a similar issue, #1812

I had previously enabled debug mode and disabled optimize tree restoration with cache due to #1754

Re-enabling optimize tree restoration with cache immediately fixed this issue (#1818) for me. I'm not yet sure if this causes #1754 to come back. Re-disabling optimize tree restoration with cache immediately causes TST to go back into the infinite reload loop.

I hope I don't have to choose between "TST only lets me interact with tabs 1 out of every 5 seconds" and "TST messes with the hierarchy of my tabs".

@jsams
Copy link

jsams commented Mar 8, 2018

I am also seeing this over the past couple of days on 58.0.2 with tst 2.4.17. I had also been hit with #1754 and had disabled the tree cache optimization. Re-enabling it kills the infinite loop of reloading the tab tree. I've opened a few tabs and the tree hasn't been mismanaged yet. Here's to hoping it stays that way.

@AVHon
Copy link

AVHon commented Mar 9, 2018

I hope I don't have to choose between "TST only lets me interact with tabs 1 out of every 5 seconds" and "TST messes with the hierarchy of my tabs".

I've opened a few tabs and the tree hasn't been mismanaged yet. Here's to hoping it stays that way.

Unfortunately, enabling optimize tree restoration with cache did cause #1754 to come back for me. Turning it off caused TST to go into the reload loop, and turning it back on caused the loop to stop, and the tabs to be shown in a sane order. (This time, anyway.) However, there are now some tabs that I can click on but that TST won't switch to.

@ProCycleDev
Copy link

ProCycleDev commented Mar 13, 2018

I was having this same problem. I managed to fix it (knock on wood) by turning off the cache, and then reordering the trees with the tabs that are broken while cache is enabled. That seems to have forced it to recalculate things and now it no longer reloads over and over while the cache is disabled.

I've noticed that the laundry list of problems (out of order tabs, tabs you can't click on to switch to or close, disappearing tabs) all happen after I move tabs to another window and then back to the main window again

@Ryman
Copy link

Ryman commented Apr 21, 2018

I've noticed that the laundry list of problems (out of order tabs, tabs you can't click on to switch to or close, disappearing tabs) all happen after I move tabs to another window and then back to the main window again

+1 on this, had the issues on a new install right after moving a tree to a new window, something weird happened which undid it and then doing it again.

@jsams
Copy link

jsams commented Apr 21, 2018

-1 I don't believe mine had anything to do with a different window. I almost never open a second window.

@piroor
Copy link
Owner

piroor commented May 13, 2018

Does this still happen with the latest development build?
https://piro.sakura.ne.jp/xul/xpi/nightly/treestyletab-we.xpi

@piroor
Copy link
Owner

piroor commented May 1, 2019

I close this because outdated.

@piroor piroor closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants